Keep dynamic patterns in their own groups #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If using multiple dynamic patterns where some point out to ../ and others would be in the '.' group, all are added to this group, but the file walker can't get out of the base directory and not all files are found.
|
Hello, @vladdu, Thanks for the PR. Unfortunately, I think this solution only works well in your specific case. Without combining patterns and when we have something like this ( I will close this PR and suggest continuing in the issue. |
|
I see. Ok, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using multiple dynamic patterns where some point out to ../ and others
would be in the '.' group, all are added to this group, but the file
walker can't get out of the base directory and not all files are found.
What is the purpose of this pull request?
Addresses #316
What changes did you make? (Give an overview)
Removed the '.' task group, as it can't contain patterns that point to places outside the base directory.
It would be possible to solve in a different way, by looking for ../ patterns, but I'm not sure if there are more cases where that could be a problem. Is having multiple task groups going to be a performance problem?
I did not create tests, as I didn't find any that work against a list of patterns. Maybe I missed them?